Skip to content

feat: check version match#1111

Open
jorgepiloto wants to merge 13 commits intomainfrom
feat/check-version-match
Open

feat: check version match#1111
jorgepiloto wants to merge 13 commits intomainfrom
feat/check-version-match

Conversation

@jorgepiloto
Copy link
Member

Fix #671 by making sure artifacts version matches the git tag that triggered a release.

@jorgepiloto jorgepiloto requested a review from a team as a code owner January 14, 2026 09:38
@jorgepiloto jorgepiloto added this to the ansys/actions@v10.3 milestone Jan 14, 2026
@github-actions github-actions bot added the enhancement General improvements to existing features label Jan 14, 2026
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @jorgepiloto, I think that the current version extraction is not working. Can you update it ? Trying it on the proposed example (ansys-project-1.2.3-py3-none-any.whl) does behave as I would expect.

jorgepiloto and others added 5 commits February 23, 2026 11:04
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Add version verification step to ensure the git tag version matches the
artifact version before creating a GitHub release. This prevents releases
with mismatched versions between the tag and the package metadata.

Fixes #671

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@moe-ad moe-ad removed this from the ansys/actions@v10.3 milestone Mar 13, 2026
@moe-ad
Copy link
Contributor

moe-ad commented Mar 18, 2026

@RobPasMue @SMoraisAnsys
Finalized things here as well, taking into consideration the changes in #1112.
Please give that PR and this one a final look.

@moe-ad moe-ad requested a review from MaxJPRey March 18, 2026 15:30
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The multi regex substitution is hard to follow.. but apart from that all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify that tagged version and package version match before release

7 participants