Skip to content

feat: tox implementation#1163

Merged
moe-ad merged 24 commits intomainfrom
feat/tox-implementation
Mar 2, 2026
Merged

feat: tox implementation#1163
moe-ad merged 24 commits intomainfrom
feat/tox-implementation

Conversation

@moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Feb 19, 2026

Closes #815. Check the issue for context that might be missing here.

Important things to note

  • Prek is used for running the pre-commit checks
  • For updating the action reference, I opted for a python script.
  • An additional environment for running python-utils/test_versions.py was also included.

@moe-ad moe-ad self-assigned this Feb 19, 2026
@moe-ad moe-ad changed the title Feat/tox implementation feat: tox implementation Feb 19, 2026
@moe-ad moe-ad force-pushed the feat/tox-implementation branch from aa6ce23 to 2ac902a Compare February 19, 2026 10:46
@github-actions github-actions bot added the enhancement General improvements to existing features label Feb 19, 2026
@moe-ad moe-ad marked this pull request as ready for review February 19, 2026 16:03
@moe-ad moe-ad requested a review from a team as a code owner February 19, 2026 16:03
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be very valuable @moe-ad, thanks for this !
I added some minor comments.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome and needed pull. Just left some requests on my side.

@moe-ad
Copy link
Contributor Author

moe-ad commented Feb 24, 2026

@jorgepiloto @SMoraisAnsys @MaxJPRey thanks for your reviews. Can you give this a look again?

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, @moe-ad. I left some general comments about the script implementation. They focus on breaking the functions into smaller pieces so things are more explicit and maintainable. My suggestion should help to remove the dry-run from all function calls.

@moe-ad moe-ad requested a review from jorgepiloto March 2, 2026 15:23
@jorgepiloto jorgepiloto force-pushed the feat/tox-implementation branch from d730243 to 9d250c9 Compare March 2, 2026 16:22
@moe-ad moe-ad merged commit 4369ae0 into main Mar 2, 2026
171 of 191 checks passed
@moe-ad moe-ad deleted the feat/tox-implementation branch March 2, 2026 18:01
moe-ad added a commit that referenced this pull request Mar 11, 2026
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Tox

5 participants