REFACTOR: remove unused method to retrieve reference primitive from terminal#1910
Draft
svandenb-dev wants to merge 2 commits intomainfrom
Hidden character warning
The head ref may contain hidden characters: "remove-grpc-unused-and-non-functiona\u00f6-method"
Draft
REFACTOR: remove unused method to retrieve reference primitive from terminal#1910svandenb-dev wants to merge 2 commits intomainfrom
svandenb-dev wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1910 +/- ##
==========================================
+ Coverage 70.20% 70.47% +0.26%
==========================================
Files 261 260 -1
Lines 42416 42630 +214
==========================================
+ Hits 29779 30044 +265
+ Misses 12637 12586 -51 🚀 New features to boost your workflow:
|
Collaborator
ecoussoux-ansys
left a comment
ecoussoux-ansys
left a comment
There was a problem hiding this comment.
I am not able to assess the logic implemented here to replace the old, dysfunctional method, sorry.
Just two comments :
- Is that same method working fine in dotnet? That one is currently not covered by tests. (Sorry if it's not a good practice to mention dotnet in a grpc PR.. I’m not sure whether you usually deal with the two separately, or whether an update to a method present in both is seen as a good opportunity to review the counterpart)
- The new logic is currently not completely covered by tests, maybe this could be improved?
Collaborator
Author
|
OK I will work on improving this. Actually I am not sure it is working in DotNet. |
2 tasks
maxcapodi78
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is removing unused method to retrieve reference primitive from terminal and tries instead using pyedb-core api to get it when available. The removed code was not working. Instead raising an error message telling what to use, as it is not a deprecation but rather another approach. In any case the previous one could not work.