REFACTOR: Grpc primitive queries refactoring#1916
Open
svandenb-dev wants to merge 15 commits intomainfrom
Open
REFACTOR: Grpc primitive queries refactoring#1916svandenb-dev wants to merge 15 commits intomainfrom
svandenb-dev wants to merge 15 commits intomainfrom
Conversation
svandenb-dev
requested review from
SMoraisAnsys,
ecoussoux-ansys and
hui-zhou-a
# Conflicts: # doc/changelog.d/1912.miscellaneous.md # src/pyedb/dotnet/database/cell/layout.py # src/pyedb/dotnet/database/modeler.py # src/pyedb/grpc/database/layout/layout.py # src/pyedb/grpc/database/modeler.py # tests/system/test_edb_layout.py
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (82.40%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1916 +/- ##
===========================================
- Coverage 70.20% 48.95% -21.26%
===========================================
Files 261 262 +1
Lines 42416 42908 +492
===========================================
- Hits 29779 21006 -8773
- Misses 12637 21902 +9265 🚀 New features to boost your workflow:
|
…ng' into grpc-primitive-queries-refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows the same logic as PR #1912. DotNet Primitives queries refactoring
PR#1912 needs to be approved first.
closes #1676