FIX: issue #1936 grpc cutout multithread with preserve model pin#1942
Open
svandenb-dev wants to merge 4 commits intomainfrom
Open
FIX: issue #1936 grpc cutout multithread with preserve model pin#1942svandenb-dev wants to merge 4 commits intomainfrom
svandenb-dev wants to merge 4 commits intomainfrom
Conversation
…d-preserve-pingroup' into issue#1936-fix-cutout-multithread-preserve-pingroup
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
==========================================
+ Coverage 70.20% 71.00% +0.79%
==========================================
Files 261 262 +1
Lines 42416 42799 +383
==========================================
+ Hits 29779 30388 +609
+ Misses 12637 12411 -226 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixing #1936 found by a user who identified a configuration which was not tested and was passing our CICD. The issue was concerning cutout multithread with grpc. When having Spice or Sparameter model assigned and the flag
preserve_components_with_model=True, using combination og ConvexHull extent computation was throwing an error because method pins_to_preserve was mixing list of int (Id) and PadstackInstance objects. To was failling on accessing position attribute when returned object was an integer.This PR:
This PR is also addressing issue #1937 with missing layer name argument in create rectangle method. Another test was added to cover this logic as it was also missing in CICD.
closes #1936
closes #1937