Skip to content

FIX: issue #1936 grpc cutout multithread with preserve model pin#1942

Open
svandenb-dev wants to merge 4 commits intomainfrom
issue#1936-fix-cutout-multithread-preserve-pingroup
Open

FIX: issue #1936 grpc cutout multithread with preserve model pin#1942
svandenb-dev wants to merge 4 commits intomainfrom
issue#1936-fix-cutout-multithread-preserve-pingroup

Conversation

@svandenb-dev
Copy link
Collaborator

@svandenb-dev svandenb-dev commented Mar 22, 2026

This PR is fixing #1936 found by a user who identified a configuration which was not tested and was passing our CICD. The issue was concerning cutout multithread with grpc. When having Spice or Sparameter model assigned and the flag preserve_components_with_model=True, using combination og ConvexHull extent computation was throwing an error because method pins_to_preserve was mixing list of int (Id) and PadstackInstance objects. To was failling on accessing position attribute when returned object was an integer.

This PR:

  • Provides returned objects consistency with always PadstackInstance objects list instead of mix Integer.
  • Adjust _create_conformal extent to handle PadstackInstance object and not Integer anymore
  • Add a test in CICD to make sure this configuration is catched and this bug is never introduced again.

This PR is also addressing issue #1937 with missing layer name argument in create rectangle method. Another test was added to cover this logic as it was also missing in CICD.

closes #1936
closes #1937

@svandenb-dev svandenb-dev self-assigned this Mar 22, 2026
@github-actions github-actions bot added the testing Anything related to testing label Mar 22, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.00%. Comparing base (5cbae21) to head (9f6b909).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1942      +/-   ##
==========================================
+ Coverage   70.20%   71.00%   +0.79%     
==========================================
  Files         261      262       +1     
  Lines       42416    42799     +383     
==========================================
+ Hits        29779    30388     +609     
+ Misses      12637    12411     -226     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev enabled auto-merge (squash) March 24, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_create_conformal() missing layer_name argument pins_to_preserve() returns inconsistent types

3 participants