Skip to content

FIX: Wave port terminal fixed issue #1909#1945

Open
svandenb-dev wants to merge 11 commits intomainfrom
wave-port-terminal-fixed
Open

FIX: Wave port terminal fixed issue #1909#1945
svandenb-dev wants to merge 11 commits intomainfrom
wave-port-terminal-fixed

Conversation

@svandenb-dev
Copy link
Collaborator

@svandenb-dev svandenb-dev commented Mar 22, 2026

This PR is fixing Wave port and Vertical Gap ports with grpc. It also fixes issue #1909

closes #1909
closes #1787

@svandenb-dev svandenb-dev self-assigned this Mar 22, 2026
@github-actions github-actions bot added the testing Anything related to testing label Mar 22, 2026
@svandenb-dev svandenb-dev changed the title FIX: Wave port terminal fixed FIX: Wave port terminal fixed issue #1909 Mar 22, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2026

Codecov Report

❌ Patch coverage is 40.29851% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.38%. Comparing base (5cbae21) to head (77a76ef).
⚠️ Report is 47 commits behind head on main.

❌ Your patch status has failed because the patch coverage (40.29%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1945      +/-   ##
==========================================
- Coverage   70.20%   69.38%   -0.83%     
==========================================
  Files         261      263       +2     
  Lines       42416    42900     +484     
==========================================
- Hits        29779    29766      -13     
- Misses      12637    13134     +497     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svandenb-dev svandenb-dev enabled auto-merge (squash) March 24, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal.is_wave_port always returning True in grpc Bug located in grpc layout_obj.py

3 participants