Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
+ Coverage 70.20% 70.89% +0.69%
==========================================
Files 261 263 +2
Lines 42416 42879 +463
==========================================
+ Hits 29779 30401 +622
+ Misses 12637 12478 -159 🚀 New features to boost your workflow:
|
ecoussoux-ansys
previously approved these changes
Mar 23, 2026
Collaborator
ecoussoux-ansys
left a comment
ecoussoux-ansys
left a comment
There was a problem hiding this comment.
Thanks for the changes that resolve the issue, great that everything is properly covered by that test you improved !
I left some minor comments if you'd like to check.
src/pyedb/grpc/database/simulation_setup/siwave_dcir_settings.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Edouard Coussoux <edouard.coussoux@ansys.com>
… into issue#1063-fix-source-to-ground
ecoussoux-ansys
approved these changes
Mar 24, 2026
Collaborator
ecoussoux-ansys
left a comment
ecoussoux-ansys
left a comment
There was a problem hiding this comment.
Approving.
Thanks for applying the suggested changes !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is fixing issue #1063.
closes #1063