Skip to content

feat: lightbox import#853

Open
pluAtAnsys wants to merge 48 commits intomainfrom
feat/lightbox
Open

feat: lightbox import#853
pluAtAnsys wants to merge 48 commits intomainfrom
feat/lightbox

Conversation

@pluAtAnsys
Copy link
Copy Markdown
Collaborator

@pluAtAnsys pluAtAnsys commented Feb 23, 2026

Description

Add support creating light import.

Issue linked

Add support working with lightbox feature #813

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Feb 23, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 95.20000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (2ccbb36) to head (5e26076).

Files with missing lines Patch % Lines
src/ansys/speos/core/component.py 92.81% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   88.32%   88.55%   +0.23%     
==========================================
  Files          44       45       +1     
  Lines        8752     8955     +203     
==========================================
+ Hits         7730     7930     +200     
- Misses       1022     1025       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pluAtAnsys pluAtAnsys added bug Something isn't working documentation Improvements or additions to documentation labels Mar 5, 2026
@pluAtAnsys pluAtAnsys self-assigned this Mar 5, 2026
@pluAtAnsys pluAtAnsys marked this pull request as ready for review March 8, 2026 20:43
@pluAtAnsys pluAtAnsys changed the title feat: lightbox feat: lightbox import Mar 9, 2026
pluAtAnsys and others added 2 commits March 24, 2026 08:43
Co-authored-by: Stefan Thöne <86405327+StefanThoene@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments that should help with the doc build. I think you reached a treshold were too many warnings from numpydoc were raised why led to the doc build being considered as a failure despite being able to build HTML & PDF :)

Comment on lines +64 to +66
# ## Create
#
# Create locally.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be more verbose ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sensor visual not updated using project.preview() Add support working with lightbox feature

5 participants