Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 88.32% 88.55% +0.23%
==========================================
Files 44 45 +1
Lines 8752 8955 +203
==========================================
+ Hits 7730 7930 +200
- Misses 1022 1025 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was
linked to
issues
Mar 5, 2026
added 3 commits
March 8, 2026 20:55
# Conflicts: # src/ansys/speos/core/generic/parameters.py
echambla
requested changes
Mar 23, 2026
Co-authored-by: Stefan Thöne <86405327+StefanThoene@users.noreply.github.com>
SMoraisAnsys
requested changes
Mar 26, 2026
Contributor
SMoraisAnsys
left a comment
There was a problem hiding this comment.
I left some minor comments that should help with the doc build. I think you reached a treshold were too many warnings from numpydoc were raised why led to the doc build being considered as a failure despite being able to build HTML & PDF :)
Comment on lines
+64
to
+66
| # ## Create | ||
| # | ||
| # Create locally. |
Contributor
There was a problem hiding this comment.
This can probably be more verbose ?
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support creating light import.
Issue linked
Add support working with lightbox feature #813
Checklist
feat: add optical property)