Skip to content

ci: add type check job and cleanup mypy refs#894

Open
SMoraisAnsys wants to merge 7 commits intomainfrom
ci/add-type-check-job
Open

ci: add type check job and cleanup mypy refs#894
SMoraisAnsys wants to merge 7 commits intomainfrom
ci/add-type-check-job

Conversation

@SMoraisAnsys
Copy link
Contributor

Description

First step into introducing type checking in PySpeos. At the moment, this modification is verbose but very light. It only checks src/ansys/speos/core/speos.py but whenever one wants to improve the type checking, removing and --ignore ... argument will allow to include the file back to the pool.

Issue linked

Associated to #481 (issue title has been updated since mypy isn't the tool anymore)

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 26, 2026
@SMoraisAnsys SMoraisAnsys force-pushed the ci/add-type-check-job branch from a04ce3c to b1bcd18 Compare March 26, 2026 15:52
@codecov
Copy link

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.32%. Comparing base (0a86917) to head (b1bcd18).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   88.60%   88.32%   -0.29%     
==========================================
  Files          44       44              
  Lines        8757     8752       -5     
==========================================
- Hits         7759     7730      -29     
- Misses        998     1022      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SMoraisAnsys SMoraisAnsys self-assigned this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants