-
-
Notifications
You must be signed in to change notification settings - Fork 908
Refactor/x-markdown toolbar with Actions component #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @HongwuQz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the user interface of the Mermaid component by integrating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors the Mermaid component to use the centralized Actions component for its toolbar, which significantly improves code consistency and maintainability by replacing bespoke button implementations. The changes are well-executed, including the necessary updates to test cases to accommodate the new DOM structure and a fix for a localization issue in the Chinese translations. Overall, this is a solid improvement.
packages/x-markdown/src/plugins/Mermaid/__test__/index.test.tsx
Outdated
Show resolved
Hide resolved
fb8d172 to
52ab067
Compare
|
highlightCode 也可以替换哈 |

🤔 This is a ...
🔗 Related Issues
close #1283
💡 Background and Solution
Background:
Refactor Mermaid component to use the unified
Actionscomponent for operation buttons, replacing custom button implementations to improve code consistency and maintainability.Solution:
@ant-design/x/es/actionscomponent to render operation buttons (copy, zoom in, zoom out, reset, download)getByLabelTextto find icons, then locate clickable container viaclosest)Changes:
divinstead ofbutton)📝 Change Log