Skip to content

feat(tools): add multi_patch tool for batch file edits#2840

Merged
tusharmath merged 3 commits intomainfrom
mulipatch-tool
Apr 7, 2026
Merged

feat(tools): add multi_patch tool for batch file edits#2840
tusharmath merged 3 commits intomainfrom
mulipatch-tool

Conversation

@amitksingh1490
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions bot added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure. labels Apr 4, 2026
Comment on lines +388 to +392
"required": [
"new_string",
"old_string",
"replace_all"
],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replace_all field is incorrectly marked as required in the OpenAI schema. This conflicts with the actual struct definition in catalog.rs where replace_all has #[serde(default)] and #[schemars(default)], making it optional with a default value of false.

This will cause issues:

  1. The LLM will always need to provide replace_all even when using the default behavior
  2. This creates inconsistency with the JSON schema snapshot which correctly omits replace_all from the required array
  3. OpenAI's strict mode will reject requests that don't include this field

Fix: Remove "replace_all" from the required array:

"required": [
  "new_string",
  "old_string"
],
Suggested change
"required": [
"new_string",
"old_string",
"replace_all"
],
"required": [
"new_string",
"old_string"
],

Spotted by Graphite

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@tusharmath tusharmath enabled auto-merge (squash) April 7, 2026 03:17
@tusharmath tusharmath merged commit 9873264 into main Apr 7, 2026
9 checks passed
@tusharmath tusharmath deleted the mulipatch-tool branch April 7, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Brand new functionality, features, pages, workflows, endpoints, etc. type: fix Iterations on existing features or infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants