feat(tools): add multi_patch tool for batch file edits#2840
Merged
tusharmath merged 3 commits intomainfrom Apr 7, 2026
Merged
Conversation
Comment on lines
+388
to
+392
| "required": [ | ||
| "new_string", | ||
| "old_string", | ||
| "replace_all" | ||
| ], |
Contributor
There was a problem hiding this comment.
The replace_all field is incorrectly marked as required in the OpenAI schema. This conflicts with the actual struct definition in catalog.rs where replace_all has #[serde(default)] and #[schemars(default)], making it optional with a default value of false.
This will cause issues:
- The LLM will always need to provide
replace_alleven when using the default behavior - This creates inconsistency with the JSON schema snapshot which correctly omits
replace_allfrom the required array - OpenAI's strict mode will reject requests that don't include this field
Fix: Remove "replace_all" from the required array:
"required": [
"new_string",
"old_string"
],
Suggested change
| "required": [ | |
| "new_string", | |
| "old_string", | |
| "replace_all" | |
| ], | |
| "required": [ | |
| "new_string", | |
| "old_string" | |
| ], |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.