feat(tool_search): add deferred tool loading support for GPT-5.4#2853
Open
amitksingh1490 wants to merge 13 commits intomainfrom
Open
feat(tool_search): add deferred tool loading support for GPT-5.4#2853amitksingh1490 wants to merge 13 commits intomainfrom
amitksingh1490 wants to merge 13 commits intomainfrom
Conversation
…onversation history
Comment on lines
+256
to
257
| let consumed_tso_indices: std::collections::HashSet<usize> = Default::default(); | ||
|
|
Contributor
There was a problem hiding this comment.
The consumed_tso_indices HashSet is created but never populated. This means the check at line 435 if consumed_tso_indices.contains(&idx) will always return false, and the logic to skip already-consumed ToolSearchOutput messages will never work.
This appears to be incomplete implementation - the code creates the tracking variable but never inserts any indices into it. If ToolSearchOutput entries should be consumed inline with assistant messages and skipped later, the code needs to actually track which indices were consumed.
// Either remove the unused tracking logic:
for (idx, entry) in messages.iter().enumerate() {
match &entry.message {
// ... handle messages without the consumed_tso_indices check
}
}
// OR implement the actual tracking when consuming inline
Suggested change
| let consumed_tso_indices: std::collections::HashSet<usize> = Default::default(); | |
| // TODO: Implement tracking of consumed ToolSearchOutput indices if needed for deduplication |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.