feat(config): allow configuration of the base_path

[tusharmath]

Fixes #2451 #1330 #2662

[graphite-app]

Test assumes FORGE_CONFIG is not set but doesn't guarantee it. If FORGE_CONFIG is set in the test environment, the test will fail because to_environment() will return the env var value instead of a path ending in "forge".

Fix: Use EnvGuard to acquire the mutex and explicitly unset the variable:

#[test]
fn test_to_environment_falls_back_to_home_dir_when_env_var_absent() {
    let _guard = EnvGuard::set(&[]); // Ensures mutex is held
    unsafe { std::env::remove_var("FORGE_CONFIG") };
    let actual = to_environment(PathBuf::from("/any/cwd"));
    assert_eq!(actual.base_path.file_name().unwrap(), "forge");
}

Suggested change

	fn test_to_environment_falls_back_to_home_dir_when_env_var_absent() {
	let actual = to_environment(PathBuf::from("/any/cwd"));
	// Without FORGE_CONFIG the base_path must end with "forge"
	assert_eq!(actual.base_path.file_name().unwrap(), "forge");
	}
	#[test]
	fn test_to_environment_falls_back_to_home_dir_when_env_var_absent() {
	let _guard = EnvGuard::set(&[]); // Ensures mutex is held
	unsafe { std::env::remove_var("FORGE_CONFIG") };
	let actual = to_environment(PathBuf::from("/any/cwd"));
	// Without FORGE_CONFIG the base_path must end with "forge"
	assert_eq!(actual.base_path.file_name().unwrap(), "forge");
	}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.