Do not remove wrapping quotes#16
Open
xoliver wants to merge 1 commit intoanton-dev-ua:masterfrom
xoliver:master
Open
Do not remove wrapping quotes#16xoliver wants to merge 1 commit intoanton-dev-ua:masterfrom xoliver:master
xoliver wants to merge 1 commit intoanton-dev-ua:masterfrom
xoliver:master
Conversation
|
Is this scheduled for release anytime soon? |
Author
|
Never heard back so I'd guess no? |
|
@anton-dev-ua If you are still supporting this tool, would be great to get this fixed. It's a subtle bug, so it's easy to overlook on PR's. Especially if you use |
|
Hi folks, I helped write the original version with Anton but have lost contact with him several years ago. Generally happy with the suggestions, but do you have any advice for how to apply them to the tool? |
|
Hi @idrisahmed251 , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @anton-dev-ua , thank you for this plugin, it's making my life so much easier!
I ran into the issue where running the plugin successive times effectively changes the content of cells, and that has caused me trouble running it multiple times (
""a value""becomes"a value"and then becomesa value). I think a formatting plugin should not alter the values if it can, as registered by somebody else in #11Here's a proposal for this, I figured I might as well contribute it back so everybody can benefit. I haven't touched the xml file on purpose since I'd like to see if you have reasons for it to behave the current way 😄
Thanks!