vote-interface: enable StableAbi for frozen-abi types #472
+212
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puhtaytow
force-pushed
the
enable-stableabi-vote-interface
branch
from
1275d78 to
099844f
Compare
puhtaytow
changed the title
puhtaytow
force-pushed
the
enable-stableabi-vote-interface
branch
from
996b200 to
3791768
Compare
puhtaytow
force-pushed
the
enable-stableabi-vote-interface
branch
from
3791768 to
27602e3
Compare
alexpyattaev
approved these changes
Dec 7, 2025
Contributor
alexpyattaev
left a comment
alexpyattaev
left a comment
There was a problem hiding this comment.
LGTM, but I am wondering if we could ever derive those impls instead.
Contributor
Author
Yup, good question.. i'm open for any solution that would work. From my pov, if we want to avoid raw distribution impl for frozen-abi / stableabi enabled types and derive it thru macro/visitor, then it would mean, every custom type (even those non frozen-abi enabled) used in the api would need to have the implementation. It might turn out that we have more raw impls than if we did it only for the already frozen-abi enabled types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables
StableAbi, functionality for frozen-abi types in entire crate.Summary of changes
All frozen-abi types got enabled
StableAbi.