Skip to content
This repository was archived by the owner on Oct 19, 2018. It is now read-only.

Conversation

@matarrese
Copy link

@matarrese matarrese commented May 8, 2017

Hi @ytung05 , can you have a look on this new pull request? As we discuss in the previous pull request, in this new one, as you recommended, to set up the program it requires changes only in the qiao.xml configuration file. For the impact of the modification, I had to change quite a lot of classes and because I'm not familiar with all the components of the project I took some assumption and decisions that they should be reviewed carefully. Please let me know your thoughts

@ytung05
Copy link
Contributor

ytung05 commented May 9, 2017

Thanks Antonia. Review in progress...

@ytung05
Copy link
Contributor

ytung05 commented May 9, 2017

The new PR is on the right path. Excellent efforts!

  1. Let us ingest file-manager, book-keeper, and others as properties to an agent in qiao.xml, so it doesn't look crowded. Keep detailed bean level configurations in beans.xml. For example,
..
  1. Use for setting doneFileHandler and/or quarantineFileHandler in PatternMatchFileInjector for consistency. They should reference to those defined at the agent level.

  2. Use the same formatter. It is hard for reviewers to find the changes in the code if a different formatter is used. I will email you the formatter if you use eclipse.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants