Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
network_idandsignature_schemefrom engine configuration instead of hardcoded values.network_idandsignature_schemeat initialization time.Description
signature_scheme: u16field toConsensusEngineand threaded it through the engine state.ConsensusEngine::with_crypto_profile(state, network_id, signature_scheme)and updatednewandwith_network_idto call it with a default scheme of1.vote_authentication_context()to returnnetwork_id: self.network_idandsignature_scheme: self.signature_schemeinstead of hardcoded values.custom_crypto_profile_is_used_for_execution_certificate_contextthat constructs an engine with a custom crypto profile and asserts emitted execution certificate fieldsnetwork_idandsignature_schemematch the configured values.docs/src/AOXCUNITY_ENGINE_ROADMAP_TR.mdwith sections on crypto-agility, evidence-first security, and recommended migration strategy (kept, not removed).Testing
custom_crypto_profile_is_used_for_execution_certificate_contextwithcargo testand all tests passed.Codex Task