-
Couldn't load subscription status.
- Fork 15.9k
Feature/extract pre commit for airflow core #57310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/extract pre commit for airflow core #57310
Conversation
|
@potiuk ^^^ Careful review please! - sure you were able to read all the text in this lightning speed? Or trusting me and CI? :-D |
|
Trusting you and CI .. I did took a look "briefly" .... |
I.e. I am checking if you are not doing anything "sneaky" - but I belive CI is way better than me to check for actual errors in this case. |
56fad0f to
24c8e7c
Compare
That looks like |
|
Parking this PR in regards of |
|
Let me try something .. It's strange it would fail like that but maybe ... |
|
Pushed a possible fixup |
Sounds reasonable... I can confirm I can reproduce it locally but ONLY when I start via |
|
Just a marker before merge:
|
|
Nope. Does not work... |
Libatomic is already installed. It looks like - possibly - somehow the system library path is removed during the installation by prek. I will comment there. |
diff --git a/dev/breeze/src/airflow_breeze/commands/release_management_commands.py b/dev/breeze/src/airflow_breeze/commands/release_management_commands.py
index dfad85b2c7..1b0f28a9d2 100644
--- a/dev/breeze/src/airflow_breeze/commands/release_management_commands.py
+++ b/dev/breeze/src/airflow_breeze/commands/release_management_commands.py
@@ -272,7 +272,7 @@ PYYAML_VERSION = "6.0.3"
AIRFLOW_BUILD_DOCKERFILE = f"""
# syntax=docker/dockerfile:1.4
FROM python:{DEFAULT_PYTHON_MAJOR_MINOR_VERSION}-slim-{ALLOWED_DEBIAN_VERSIONS[0]}
-RUN apt-get update && apt-get install -y --no-install-recommends git curl
+RUN apt-get update && apt-get install -y --no-install-recommends libatomic1 git curl
RUN pip install uv=={UV_VERSION}
RUN --mount=type=cache,id=cache-airflow-build-dockerfile-installation,target=/root/.cache/ \
uv pip install --system ignore pip=={AIRFLOW_PIP_VERSION} hatch=={HATCH_VERSION} \Could you try this patch? I think the |
d14f530 to
4aa3171
Compare
Thanks @j178 for the fast feedback! Re-based on the leftovers and cleaned the PR, applied the workaround as proposed. Let's see if CI turns green via this. |
|
closes: j178/prek#973 |
4aa3171 to
b449dfc
Compare
|
Rebased to see. Indeed - release management commands use their own smaller "airflow-build-dockerfile" |
b449dfc to
265159d
Compare
265159d to
47ed100
Compare
|
We have no "luck" with this PR but all errors seem unrelated. Same errors on main. Therefore: merging. THANKS @j178 for the proposed fix! |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker a6d3e2d v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
As we also did not backport #57315 would also skip here? Or should we? |
Following #57181 this is now a batch for all prek hooks that are "just" solely for providers to split out from root:
As prek is supporting monorepo now and go SDK was the front-runner, Airflow-Core is now the next piece that with this PR is proposed to be split-out from global pre-commit hook list into the provider space.
Note: This is the crown and msot probably atm the last thing to move. Careful review please!