Fix JWT tokens appearing in task logs#62782
Closed
sunank200 wants to merge 2 commits intoapache:mainfrom
Closed
Conversation
- Stop logging full workload object in execute_workload; log only dag_id, task_id, run_id, log_path so the JWT token is never passed to the logger. - Extend redact_jwt structlog processor to redact JWTs inside Pydantic-like objects (model_dump) and to replace 'token' key values with *** so any workload-like object logged elsewhere is safe. closes: apache#62773 Made-with: Cursor
| raise ValueError(f"Executor does not know how to handle {type(workload)}") | ||
|
|
||
| log.info("Executing workload", workload=workload) | ||
| log.info( |
Contributor
There was a problem hiding this comment.
You could keep the same logging statement here and instead set the JWT-containing attribute as a pydantic.SecretStr, which will by default redact the field from logs.
Contributor
|
Closing in favor of #62964 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokenkey values with***so any workload-like object logged elsewhere is safe.closes: #62773
Was generative AI tooling used to co-author this PR?
Made-with: Cursor
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.