fix(google-ads): support flat extra format from connection form#62791
Open
yuseok89 wants to merge 4 commits intoapache:mainfrom
Open
fix(google-ads): support flat extra format from connection form#62791yuseok89 wants to merge 4 commits intoapache:mainfrom
yuseok89 wants to merge 4 commits intoapache:mainfrom
Conversation
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a mismatch between the Google Ads connection form and the hook's expected input format. I discovered this issue while testing another PR(#61334). When users filled in the connection form (developer token, client ID, client secret, refresh token), the values were stored as flat keys in
extra. However, the hook only read the nestedgoogle_ads_clientstructure, causing connection failures.Before
Error when entering values via the connection form:
What the hook expected (nested format):
After
Supported connection form fields (flat format stored in extra):
How the connection was tested:
The hook now accepts both:
developer_token,client_id, etc. at top levelgoogle_ads_clientwith nested keysConnection works when entering values via the connection form.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.