Fix XCom edit modal value not repopulating on reopen.#62798
Open
Arbaaz123676 wants to merge 2 commits intoapache:mainfrom
Open
Fix XCom edit modal value not repopulating on reopen.#62798Arbaaz123676 wants to merge 2 commits intoapache:mainfrom
Arbaaz123676 wants to merge 2 commits intoapache:mainfrom
Conversation
Arbaaz123676
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
bbovenzi
approved these changes
Mar 4, 2026
pierrejeambrun
requested changes
Mar 5, 2026
Member
There was a problem hiding this comment.
This doesn't seem to fix the problem for me and some pieces of the change set seems irrelevant. (also CI need fixing)
Screen.Recording.2026-03-05.at.17.38.11.mov
Can you double check or eventually provide a recording of this scenario working on your end?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the XCom value was not displayed when reopening the edit modal after updating it.
Root Cause
The modal lifecycle and query behavior caused stale or skipped state updates when reopening the modal, leading to an empty value field.
Changes
lazyMountfrom the dialog to ensure proper unmount/remount behavior.datainstead ofdata?.value !== undefined.GetXcomEntriesandGetXcomEntryafter update.Result
The XCom edit modal now consistently repopulates the latest value when reopened.
Fixes #61486