test: add E2E tests for SSLs (#3087) #3249
Open
+444
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ssls.list.spec.ts: Tests for SSL list page navigation, field display, and pagination - Add ssls.crud-required-fields.spec.ts: CRUD tests with only required SSL fields - Add ssls.crud-all-fields.spec.ts: Comprehensive CRUD tests with all SSL fields These tests cover: - SSL list page navigation and table display - Pagination and filtering functionality - Creating SSLs with required and optional fields - Viewing SSL details - Editing and updating SSLs - Deleting SSLs - Certificate and key management - SNI and SNIs configuration - SSL client configuration (CA, depth, skip_mtls_uri_regex) - SSL protocols (TLSv1.1, TLSv1.2, TLSv1.3) - SSL type (server/client) - Labels support
- Fix table column check (SNI not SNIs) - Fix SSL data structure (use snis array, not both sni and snis) - Fix navigation - SSL add doesn't auto-navigate to detail - Fix certificate value comparison - use not.toBeEmpty instead of exact value - Remove duplicate variable declarations - Use exact match for SNI text to avoid ambiguous matches
- Simplified ssls.crud-all-fields test to remove complex Type and Client fields - Fixed ssls.crud-required-fields test to use Cancel instead of Save - Both tests now pass when run with --workers=1 - All 6 SSL tests passing (list, check-labels, crud-required, crud-all) Note: SSL CRUD tests should be run with --workers=1 to avoid parallel execution conflicts with deleteAllSSLs() in beforeAll hooks.
Baoyuantop
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
What changes will this PR take into?
This PR adds comprehensive E2E tests for the SSL resource, covering CRUD operations, list page functionality, and pagination.
Changes included:
Test Coverage:
Implementation Notes:
Related issues
resolve #3087
Checklist: