fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response #12853
+133
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
Baoyuantop
reviewed
Jan 4, 2026
apisix/plugins/brotli.lua
Outdated
|
|
||
| if not matched[1] then | ||
| -- strong etag, downgrade it | ||
| ngx.header.etag = [[W/"]] .. matched[2] .. [["]] |
Contributor
There was a problem hiding this comment.
It is recommended to use core.response.set_header to maintain consistent code style.
Contributor
There was a problem hiding this comment.
Hi @yuweizzz, similar issues exist in other parts of the code; please correct them all.
Contributor
Author
There was a problem hiding this comment.
I will check it again.
| end | ||
|
|
||
| local regex = [[^(W/)?"(.*)"$]] | ||
| local matched, err = ngx.re.match(etag, regex, "jo") |
Contributor
There was a problem hiding this comment.
The err variable is declared but never used; if a regular expression match fails, an error should be logged.
5 tasks
Baoyuantop
added
the
wait for update
Baoyuantop
added
awaiting review
and removed
wait for update
Baoyuantop
added
wait for update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downgrade etag when in needed.
Which issue(s) this PR fixes:
Fixes #12707
Checklist