CI: Potential fix for code scanning alert no. 10: Workflow does not contain permissions#13028
Draft
Baoyuantop wants to merge 1 commit intomasterfrom
Draft
CI: Potential fix for code scanning alert no. 10: Workflow does not contain permissions#13028Baoyuantop wants to merge 1 commit intomasterfrom
Baoyuantop wants to merge 1 commit intomasterfrom
Conversation
…ontain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Baoyuantop
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/apache/apisix/security/code-scanning/10
In general, the fix is to explicitly declare minimal
GITHUB_TOKENpermissions for this workflow, either at the workflow root (applies to all jobs) or under the specificcheck-licensejob. Since there is only one job, either approach works; adding it at the workflow root is clear and future-proof if more jobs are added.The best minimal fix without changing existing functionality is to add:
near the top-level of the workflow, between
name:andon:(or just abovejobs:). Theapache/skywalking-eyesaction only needs to read repository contents to scan license headers; it does not need to write to the repo, issues, or PRs in the current snippet. Keepingcontents: readensures the workflow can still check out and read files while restricting any write capabilities. No imports or additional methods are needed, as this is purely a YAML configuration change.Concretely, edit
.github/workflows/license-checker.ymlaround lines 19–26 to insert apermissions:block at the root level.Suggested fixes powered by Copilot Autofix. Review carefully before merging.