fix: Pass explicit length in Struct makeData calls#404
Open
rustyconover wants to merge 1 commit intoapache:mainfrom
Open
fix: Pass explicit length in Struct makeData calls#404rustyconover wants to merge 1 commit intoapache:mainfrom
rustyconover wants to merge 1 commit intoapache:mainfrom
Conversation
In `setChildAt`, pass `length: data.length` to preserve the batch's row count. In `_InternalEmptyPlaceholderRecordBatch`, pass `length: 0` explicitly. Both call sites previously relied on reducing over children to derive length, which silently defaults to 0 when children is empty. Closes apache#403 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rustyconover
force-pushed
the
fix/visitstruct-zero-children-length-default
branch
from
a9e56d1 to
64a5428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
length: data.lengthinsetChildAtto preserve the batch's row count when constructing Struct datalength: 0explicitly in_InternalEmptyPlaceholderRecordBatchinstead of relying on reduce-over-children fallbackmakeDatawith empty children andsetChildAtrow count preservationCloses #403
Test plan
makeDatawith empty children preserves explicit lengthmakeDatawith empty children and no length defaults to 0setChildAtpreservesnumRowsafter column replacementyarn test -t src)🤖 Generated with Claude Code