feat: parse DataType List, ListView, LargeList, LargeListView, FixedSizeList
#8649
+175
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dqkqd
force-pushed
the
support-parse-list
branch
from
5826fb5 to
e25e4a1
Compare
dqkqd
changed the title
nullability and field for DataType::ListList, ListView, LargeList, LargeListView, FixedSizeList
dqkqd
commented
Oct 18, 2025
|
|
||
| "nullable" => Token::Nullable, | ||
| "field" => Token::Field, | ||
| "x" => Token::X, |
There was a problem hiding this comment.
I cannot find a better name for x.
Using Time seems confuse with time related data types.
alamb
changed the title
List, ListView, LargeList, LargeListView, FixedSizeListList, ListView, LargeList, LargeListView, FixedSizeList
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
dqkqd
force-pushed
the
support-parse-list
branch
from
bc35472 to
b6d502c
Compare
|
Thank you @alamb for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
parse_data_typeforList,ListView,LargeList,LargeListView,FixedSizeList,Union,Map,RunEndCoded. #8648.This PR only implements for list types to make review easier.
Rationale for this change
The format for
DataType::Listincludes:List(Int64): list not nullable.List(nullable Int64): list nullable.List(nullable Int64, field: 'foo'): list nullable with field.List(nullable Int64, metadata: {"foo1": "value1"}): list with metadata.(... The list goes on for
ListView,LargeList,LargeListView,FixedSizeList)parse_data_typecannot (or incorrectly) work on those data types listed above.What changes are included in this PR?
Token::...to support newDisplayformat for list types introduced in ImproveDisplayforDataType#8351(e.g.
FixedSizeList(5 x nullable Int64, field: 'foo').fn nullableto check whether nested data type is nullable.parse_single_quoted_stringandparse_list_field_nameto handlefield: 'foo'.Are these changes tested?
Yes. Added round trip tests.
Are there any user-facing changes?
Yes. This is related to #8351