- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1k
 
          feat: add new_repeated to ByteArray
          #8659
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            mbrobbel
  merged 10 commits into
  apache:main
from
rluvaton:add-repeat-helpear-for-bytes-array
  
      
      
   
  Nov 3, 2025 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            10 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      5ac9879
              
                perf: add optimized function to create offset with same length
              
              
                rluvaton e172f2e
              
                add tests
              
              
                rluvaton 3317a39
              
                updated comment
              
              
                rluvaton 5f01d05
              
                perf: add `repeat_slice_n_times` to `MutableBuffer`
              
              
                rluvaton 72070dc
              
                simplify implementation
              
              
                rluvaton 9948aa3
              
                feat: add `new_repeated` and `try_new_repeated` to `ByteArray`
              
              
                rluvaton 5b937ca
              
                Merge branch 'add-from-length-repeated-for-offset-buffer' into add-re…
              
              
                rluvaton 78b223f
              
                fix
              
              
                rluvaton 813e970
              
                Merge branch 'main' into add-repeat-helpear-for-bytes-array
              
              
                rluvaton 670d301
              
                add failing tests
              
              
                rluvaton File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 0, do we not know how many elements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the responsibility of the repeat
And 0 will use null pointer so it will no allocate anything unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!