Use branchless index clamping and add get_batch_direct to RleDecoder#9585
Open
Dandandan wants to merge 5 commits intoapache:mainfrom
Open
Use branchless index clamping and add get_batch_direct to RleDecoder#9585Dandandan wants to merge 5 commits intoapache:mainfrom
Dandandan wants to merge 5 commits intoapache:mainfrom
Conversation
When bit_width guarantees all possible indices fit within the dictionary, use unchecked indexing to allow LLVM to unroll the dict gather loop 4x with paired loads/stores instead of scalar with per-element bounds checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add RleDecodedBatch enum and get_batch_direct method that exposes RLE vs bit-packed batches via callback, allowing callers to handle each case optimally without going through the index buffer. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace if/else checked/unchecked branching with a single branchless .min(max_idx) clamp. This prevents UB on corrupt parquet files while avoiding per-element bounds checks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
These are only used by the arrow dictionary_index decoder. Without the arrow feature, they appear as dead code to clippy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
run benchmark arrow_reader_clickbench |
|
🤖 Arrow criterion benchmark running (GKE) | trigger |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Details
Resource Usagebase (merge-base)
branch
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9581
Rationale
The RLE dictionary decoding path uses if/else branching to select between checked and unchecked indexing. A branchless
.min(max_idx)clamp is simpler and prevents UB on corrupt data.What changes are included in this PR?
.min(max_idx)clamp inget_batch_with_dictRleDecodedBatchenum andget_batch_directmethod that exposes RLE vs bit-packed batches via callbackRleDecodedBatchandget_batch_directbehindarrowfeature flagAre there any user-facing changes?
No.
🤖 Generated with Claude Code