GH-47846: [Format] clarify the encoding of the fp16 substrait literal #47847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't love the wording but I think it is precise. I'm open to any clearer way of stating this. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #47846
What changes are included in this PR?
This is only a format change. The C++ Substrait library does not (tmk) support encoding fp16 literals via Substrait. This is to support a proposed Datafusion change (apache/datafusion#18086).
Are these changes tested?
Only via the Datafusion change
Are there any user-facing changes?
This is a clarification to the Substrait spec for Arrow types that are not standard Substrait types