GH-47936: [R] docgen.R requires installed package instead of current working code #47940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: R
awaiting committer review
jonkeane
approved these changes
Nov 6, 2025
Comment on lines
135
to
138
| warning( | ||
| "devtools is not installed. Using installed arrow package instead of current working code.\n", | ||
| "To generate accurate docs, install the current branch version of arrow first." | ||
| ) |
Member
There was a problem hiding this comment.
I don't mind leaving this as is, but I wonder if this actually should be an error? Is there a case where one would want to generate the stale docs?
Member
Author
There was a problem hiding this comment.
Fair, I was just being conservative in my changes, but given this is a dev script I don't need to.
Member
Author
There was a problem hiding this comment.
I guess it's cool to do R CMD INSTALL . instead of devtools though? Just wanna give options.
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting change review
|
After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 4077efe. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
R package doc generation uses installed version of package so creates wrong docs if older version installed.
What changes are included in this PR?
Use devtools::load_all() to load the package first when running locally.
Are these changes tested?
CI should be happy, but I did test locally.
Are there any user-facing changes?
Nah.