Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Oct 26, 2025

Rationale for this change

  • checksum update not part of instructions
  • non-obvious need to call make clean

What changes are included in this PR?

  • update instructions and makefile

Are these changes tested?

I will test locally before marking this as ready for review

Are there any user-facing changes?

No

@github-actions
Copy link

⚠️ GitHub issue #47939 has been automatically assigned in GitHub to PR creator.

@thisisnic thisisnic marked this pull request as ready for review October 28, 2025 17:23
@thisisnic thisisnic requested a review from assignUser as a code owner October 28, 2025 17:23
@thisisnic thisisnic requested a review from amoeba October 28, 2025 17:23
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Left one comment about the checksums change.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 28, 2025
@thisisnic thisisnic merged commit 527ddb0 into apache:main Oct 28, 2025
13 checks passed
@thisisnic thisisnic removed the awaiting changes Awaiting changes label Oct 28, 2025
@github-actions github-actions bot added awaiting committer review Awaiting committer review awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Oct 28, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 527ddb0.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants