Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Oct 28, 2025

Rationale for this change

If we use bash -i -c as ENTRYPOINT, we need to pass command line as a string such as archery docker run cpp-jni 'ls -la' not archery docker run cpp-jni ls -lah.

Our compose.yaml assumes the latter style. So our command line in compose.yaml is ignored.

What changes are included in this PR?

Remove needless SHELL and ENTRYPOINT.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #47970 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 28, 2025
@kou kou added the CI: Extra: C++ Run extra C++ CI label Oct 28, 2025
@kou
Copy link
Member Author

kou commented Oct 28, 2025

Hmm... Boost detection is failing:

https://github.com/apache/arrow/actions/runs/18862133948/job/53822393392?pr=47972#step:6:2833

CMake Warning at /usr/local/share/cmake-3.29/Modules/FindBoost.cmake:2234 (message):
  No header defined for process; skipping header check (note: header-only
  libraries have no designated component)
Call Stack (most recent call first):
  /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:898 (_find_package)
  cmake_modules/ThirdpartyToolchain.cmake:310 (find_package)
  cmake_modules/ThirdpartyToolchain.cmake:1287 (resolve_dependency)
  CMakeLists.txt:523 (include)


CMake Error at /usr/local/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Boost (missing: Boost_INCLUDE_DIR filesystem system)
  (Required is at least version "1.64")
Call Stack (most recent call first):
  /usr/local/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake-3.29/Modules/FindBoost.cmake:2393 (find_package_handle_standard_args)
  /opt/vcpkg/scripts/buildsystems/vcpkg.cmake:898 (_find_package)
  cmake_modules/ThirdpartyToolchain.cmake:310 (find_package)
  cmake_modules/ThirdpartyToolchain.cmake:1287 (resolve_dependency)
  CMakeLists.txt:523 (include)


-- Configuring incomplete, errors occurred!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting committer review Awaiting committer review CI: Extra: C++ Run extra C++ CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant