GH-48776: [CI][Ruby][Windows] Ensure removing temporary files #48777
+52
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: Ruby
Component: GLib
awaiting committer review
kou
force-pushed
the
ci-ruby-windows-suppress-warnings
branch
from
c961395 to
c374570
Compare
kou
commented
Jan 8, 2026
Member
Author
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
https://github.com/apache/arrow/actions/runs/20809455332/job/59770177593?pr=48777#step:13:94 doesn't have any finalizer warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We can't remove a file if someone is still opening the file on Windows.
We use
Tempfilefor tests. It removes associated file when it's GC-ed. If we still open the associated file, the GC process reports the following warning:What changes are included in this PR?
Ensure removing temporary files.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes. Only for
gparquet_arrow_file_reader_close().