GH-37958: [MATLAB] Centralize Command Window hyperlink formatting#49414
GH-37958: [MATLAB] Centralize Command Window hyperlink formatting#49414kriyanshii wants to merge 6 commits intoapache:mainfrom
Conversation
Reduce duplicate hyperlink formatting logic in Command Window display helpers. * Add a shared hyperlink utility in MATLAB display helpers. * Use it in schema string rendering and test helpers. Not run (manual check in MATLAB Command Window). Yes. Command Window display now uses a shared hyperlink helper. * GitHub Issue: apache#37958
kriyanshii
requested review from
kevingurney,
kou and
sgilmore10
as code owners
matlab/src/matlab/+arrow/+tabular/+internal/+display/getSchemaString.m
Outdated
Show resolved
Hide resolved
github-actions
bot
added
awaiting committer review
|
Hi @kriyanshii, It looks like there's some CI failures. Could you take a look? Thanks, |
|
Please reach out to @kevingurney or me if you have any specific questions that we can answer! Best, |
|
@sgilmore10 yess! |
- Add getClassNameForDisplay, getNumString, makeDimensionString helpers - Update Array, Schema, Tabular, Type, Field display to use short class names with optional hyperlinks - Fix tSchema TestIsEqualTrue/False: use table() instead of table for empty schema
|
Hi @kriyanshii, It looks like there's still some CI failures. I took a quick look at the changes, and it seems like there's more code churn than I expect (e.g. I'm not sure why Do you mind taking a fresh look at this? Best, |
|
I am starting everything cleanly from scratch. Sorry for the delay. |
No worries! :) |
|
Hi @kriyanshii, Looks like there's some CI failures you may want to investigate. |
2 participants
Rationale for this change
Reduce duplicate hyperlink formatting logic in Command Window display helpers.
What changes are included in this PR?
Are these changes tested?
Not run (manual check in MATLAB Command Window).
Are there any user-facing changes?
Yes. Command Window display now uses a shared hyperlink helper.