GH-49539: [C++][Parquet] Fix argument count check in parquet_scan#49540
Open
domibel wants to merge 1 commit intoapache:mainfrom
Open
GH-49539: [C++][Parquet] Fix argument count check in parquet_scan#49540domibel wants to merge 1 commit intoapache:mainfrom
domibel wants to merge 1 commit intoapache:mainfrom
Conversation
|
|
raulcd
changed the title
raulcd
reviewed
Mar 18, 2026
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good to me, I've triggered CI. Instead of removing the PR template, could you fill it with the required sections? The message goes directly into the commit history and it's helpful for us to be consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Running parquet-scan without arguments currently triggers a confusing IOError instead of showing how to use the tool.
What changes are included in this PR?
Updated the argument validation from argc < 1 (always false) to argc < 2.
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
Old behavior:
$ parquet-scan
Parquet error: IOError: Failed to open local file ''. Detail: [errno 2] No such file or directory
New behavior:
$ parquet-scan
Usage: parquet-scan [--batch-size=] [--columns=...]