WIP: [R] Verify CRAN release 23.0.1.2#49589
Closed
thisisnic wants to merge 4 commits intoapache:maint-23.0.1.1-rfrom
Closed
WIP: [R] Verify CRAN release 23.0.1.2#49589thisisnic wants to merge 4 commits intoapache:maint-23.0.1.1-rfrom
thisisnic wants to merge 4 commits intoapache:maint-23.0.1.1-rfrom
Conversation
…rInFrame (apache#49530) ### Rationale for this change CI job shows NOTE due to "non-API call" Rf_findVarInFrame ### What changes are included in this PR? Remove non-API calls to doesn't come up on CRAN notes ### Are these changes tested? I'll do some CI testing ### Are there any user-facing changes? No ### AI use Basically all of this, with Claude Opus 4.5 but I did ask multiple questions on the reasoning behind the changes and alternatives - don't understand 100% but looks reasonable to me * GitHub Issue: apache#49529 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
### Rationale for this change Resolve the crossbow failure, I've already created an issue upstream ### What changes are included in this PR? Skipping a test under sanitization ### Are these changes tested? They are the tests ### Are there any user-facing changes? No * GitHub Issue: apache#49578 Authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
Member
Author
|
@github-actions crossbow submit --group r |
37 tasks
|
Revision: 8679f11 Submitted crossbow builds: ursacomputing/crossbow @ actions-a8bb74e4a7
|
Member
Author
|
Most of these failures are just CI things to do with fs now requiring system libuv and not defaulting to installing the bundled one. |
thisisnic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge, CI for CRAN checks