Skip to content

Move GetExperiments to a common place for other boot.go#37492

Draft
shunping wants to merge 4 commits intoapache:masterfrom
shunping:refactor-experiments
Draft

Move GetExperiments to a common place for other boot.go#37492
shunping wants to merge 4 commits intoapache:masterfrom
shunping:refactor-experiments

Conversation

@shunping
Copy link
Collaborator

@shunping shunping commented Feb 3, 2026

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @shunping, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve code organization and reusability within the Go SDK by centralizing the GetExperiments utility function. This function, responsible for parsing experiment flags from pipeline options, has been relocated to a shared tools package, allowing multiple boot.go implementations to access a single, well-tested version. This refactoring reduces redundancy and enhances maintainability.

Highlights

  • Centralization of GetExperiments function: The GetExperiments function, previously defined locally in sdks/python/container/boot.go, has been moved to a common utility file: sdks/go/container/tools/pipeline_options.go.
  • Code Reuse: The sdks/python/container/boot.go file now imports and utilizes the centralized tools.GetExperiments function, eliminating code duplication.
  • New Unit Tests: Comprehensive unit tests for the GetExperiments function have been added in sdks/go/container/tools/pipeline_options_test.go, covering various input scenarios including valid, empty, and invalid JSON.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/go/container/tools/pipeline_options.go
    • Added PipelineOptionsData and OptionsData structs for JSON unmarshaling.
    • Implemented GetExperiments function to extract experiment strings from JSON pipeline options.
  • sdks/go/container/tools/pipeline_options_test.go
    • Added TestGetExperiments with multiple test cases covering different JSON inputs and expected experiment arrays.
  • sdks/python/container/boot.go
    • Removed the local getExperiments function and its associated data structures.
    • Updated the call site to use tools.GetExperiments from the newly centralized location.
Activity
  • No specific human activity (comments, reviews, progress updates) has been recorded for this pull request beyond its initial creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@shunping shunping force-pushed the refactor-experiments branch from 9969025 to e233424 Compare February 3, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant