Revert "[Python] Add take(n) convenience for PCollection"

[tvalentyn]

Reverts #37470

R: @jrmccluskey or @damccorm

cc: @shaheeramjad

[gemini-code-assist]

Summary of Changes

Hello @tvalentyn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request fully reverts the introduction of the take(n) convenience method for PCollection and its underlying Take PTransform. The original feature aimed to provide a deterministic way to extract the first N elements from a PCollection. This revert removes all associated code, tests, and documentation entries for this functionality, effectively undoing the previous addition.

Highlights

• Feature Removal: The take(n) method from the PCollection class, which previously allowed taking the first N elements deterministically, has been removed.
• PTransform Deletion: The Take PTransform and its associated take convenience function have been deleted from apache_beam.transforms.util.
• Test Code Removal: All unit tests for the Take PTransform and take function have been eliminated from apache_beam.transforms.util_test.py.
• Documentation Update: The CHANGES.md file has been updated to remove the entry for the take(n) feature.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• CHANGES.md
  • Removed the feature entry for "(Python) Added take(n) convenience for PCollection" from the "New Features / Improvements" section.
• sdks/python/apache_beam/pvalue.py
  • Deleted the take(n) method, including its docstring and implementation, from the PCollection class.
• sdks/python/apache_beam/transforms/util.py
  • Removed the import of Top from apache_beam.transforms.combiners.
  • Removed Take and take from the __all__ export list.
  • Deleted the entire Take PTransform class and the take convenience function.
• sdks/python/apache_beam/transforms/util_test.py
  • Removed the entire TakeTest class, which contained all test cases for the take functionality, including tests for function and method syntax, handling more elements than available, single elements, all elements, and invalid n values.

Activity

• No specific human activity (comments, reviews, etc.) was provided in the context for this pull request.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers