Conversation
Summary of ChangesHello @jrmccluskey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the PyArrow dependency range to ensure compatibility with Python 3.14 and to align with currently supported Python versions by removing older, incompatible PyArrow versions from the lower bound. The changes involve adjusting the core dependency declaration and updating the test suite to reflect these new version constraints, thereby maintaining a robust and up-to-date dependency landscape. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request updates the PyArrow dependency bounds, primarily to ensure compatibility with Python 3.14. The changes correctly modify setup.py to adjust the version constraints and update the tox.ini test matrix to cover the new range of PyArrow versions. A minor adjustment in a test file seems to be a necessary fix related to these dependency changes. I've identified one potential issue in the tox.ini configuration that could lead to test failures.
|
The PreCommit failure is apache_beam/utils/multi_process_shared_test.py::MultiProcessSharedSpawnProcessTest::test_unsafe_hard_delete_autoproxywrapper and is red on master |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
PyArrow bounds need to be updated to include a version compatible with Python 3.14. This also increments the lower bound to remove versions that do not support any of Beam's currently supported Python versions.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.