Skip to content

feat: avoid expensive str() calls in enforce_ex when logging is disabled #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsluoyz merged 5 commits into from
Feb 2, 2026
Merged

feat: avoid expensive str() calls in enforce_ex when logging is disabled #421

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cb4fbd
Initial plan
Copilot Feb 2, 2026
5808193
Optimize logging in enforce_ex to avoid unnecessary str() calls
Copilot Feb 2, 2026
651a352
Refactor logging code to eliminate duplication
Copilot Feb 2, 2026
48abb7f
Fix: apply Black formatting to test file
Copilot Feb 2, 2026
3d89944
Update test_enforcer.py
hsluoyz Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions casbin/core_enforcer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,17 +508,18 @@ def enforce_ex(self, *rvals):
result = effect_to_bool(final_effect)

# Log request.

req_str = "Request: "
req_str = req_str + ", ".join([str(v) for v in rvals])

req_str = req_str + " ---> %s" % result
if result:
self.logger.info(req_str)
else:
# leaving this in warning for now, if it's very noise this can be changed to info or debug,
# or change the log level
self.logger.warning(req_str)
if (result and self.logger.isEnabledFor(logging.INFO)) or (
not result and self.logger.isEnabledFor(logging.WARNING)
):
req_str = "Request: "
req_str = req_str + ", ".join([str(v) for v in rvals])
req_str = req_str + " ---> %s" % result
if result:
self.logger.info(req_str)
else:
# leaving this in warning for now, if it's very noise this can be changed to info or debug,
# or change the log level
self.logger.warning(req_str)

explain_rule = []
if explain_index != -1 and explain_index < policy_len:
Expand Down