Skip to content

Fix: missing validation for tids when #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: missing validation for tids when #1361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion src/backend/access/nbtree/nbtree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,37 @@ _bt_validate_tid(Relation irel, ItemPointer h_tid)
{
itup = (IndexTuple) PageGetItem(page,
PageGetItemId(page, offnum));
if (ItemPointerEquals(&itup->t_tid, h_tid))
if(BTreeTupleIsPosting(itup))
{
Copy link
Contributor

@my-ship-it my-ship-it Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test cases?

ItemPointer current;
for (int i = 0; i < BTreeTupleGetNPosting(itup); i++)
{

current = BTreeTupleGetPostingN(itup, i);

if (ItemPointerEquals(current, h_tid) )
{
Form_pg_attribute key_att = TupleDescAttr(RelationGetDescr(irel), 0);
Oid key = InvalidOid;
bool isnull;
if (key_att->atttypid == OIDOID)
{
key = DatumGetInt32(
index_getattr(itup, 1, RelationGetDescr(irel), &isnull));
elog(ERROR, "found tid (%d,%d), %s (%d) already in index (%s)",
ItemPointerGetBlockNumber(h_tid), ItemPointerGetOffsetNumber(h_tid),
NameStr(key_att->attname), key, RelationGetRelationName(irel));
}
else
{
elog(ERROR, "found tid (%d,%d) already in index (%s)",
ItemPointerGetBlockNumber(h_tid), ItemPointerGetOffsetNumber(h_tid),
RelationGetRelationName(irel));
}
}
}
}
else if (ItemPointerEquals(&itup->t_tid, h_tid))
{
Form_pg_attribute key_att = TupleDescAttr(RelationGetDescr(irel), 0);
Oid key = InvalidOid;
Expand Down
Loading