Skip to content

Fix assertion failure in getNdvBySegHeapTuple for empty partitions. #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhangwenchao-123 wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −8
Open

Fix assertion failure in getNdvBySegHeapTuple for empty partitions. #1599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions src/backend/commands/analyzeutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,17 +759,31 @@ getNdvBySegHeapTuple(AttStatsSlot * *ndvbsSlots, HeapTuple *heaptupleStats, floa
(void) get_attstatsslot(ndvbsSlots[i], heaptupleStats[i],
STATISTIC_KIND_NDV_BY_SEGMENTS, InvalidOid, ATTSTATSSLOT_VALUES);

if ((InvalidOid != ndvbsSlots[i]->valuetype && // result is not empty
// not empty partition with invalid ndvbs
(relTuples[i] > 0 && DatumGetFloat8(ndvbsSlots[i]->values[0]) == 0)) ||
// not empty partition without ndvbs
(InvalidOid == ndvbsSlots[i]->valuetype && relTuples[i] > 0)) {
valid = false;
break;
if (ndvbsSlots[i]->valuetype != FLOAT8OID)
{
/*
* NDV_BY_SEGMENTS slot not found or has unexpected type.
* Non-empty partitions must have valid NDV_BY_SEGMENTS;
* empty partitions (relTuples == 0) can be skipped.
*/
if (relTuples[i] > 0)
{
valid = false;
break;
}
pfree(ndvbsSlots[i]);
ndvbsSlots[i] = NULL;
continue;
}

Assert(ndvbsSlots[i]->valuetype == FLOAT8OID);
Assert(ndvbsSlots[i]->nvalues == 1);

/* Non-empty partition with zero NDV is suspicious */
if (relTuples[i] > 0 && DatumGetFloat8(ndvbsSlots[i]->values[0]) == 0)
{
valid = false;
break;
}
}
return valid;
}
Expand Down
Loading