Skip to content

Conversation

@NPdocker
Copy link
Contributor

@NPdocker NPdocker commented Dec 23, 2020

Update syntax for cloud-init

Update syntax for actual CloudStack Documentation.
@yadvr
Copy link
Member

yadvr commented Dec 30, 2020

LGTM, we need one more review, can you check @weizhouapache @onitake thnx

@onitake
Copy link
Contributor

onitake commented Jan 4, 2021

Hi @NPdocker - can you clarify why this PR is necessary?
Was there a configuration format change in cloud-init?

@yadvr
Copy link
Member

yadvr commented Jan 11, 2021

With the other PR merged, do we need this - can you check and advise @onitake @NPdocker @weizhouapache ?

@weizhouapache
Copy link
Member

@rhtyd
I have same question as @onitake .
we use the old config in vms, it works fine.

      datasource:
        CloudStack: {}
        None: {}
      datasource_list:
        - CloudStack

@onitake
Copy link
Contributor

onitake commented Jan 11, 2021

I think the reason for the previous stanza was that older cloud-init versions did not propagate anything without explicitly mentioning CloudStack both in datasource and datasource_list. This might have changed, or the missing None in datasource_list prevented it from working.

@Doni7722 Could you verify if datasource_list: [ CloudStack, None ] without datasource works for us? Thanks!

@Doni7722
Copy link

@onitake I'll test that today and let you know the results.

@Doni7722
Copy link

@onitake I did verify and can confirm that it works fine with datasource_list: [ CloudStack, None ] without datasource

@yadvr yadvr merged commit c8821a6 into apache:master May 24, 2021
@yadvr yadvr added this to the 4.16 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants