-
Notifications
You must be signed in to change notification settings - Fork 120
vm: fix display name, internal name notes #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: fix display name, internal name notes #177
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
| User-Provided Display Name vm.instancename.flag User Display Name Hostname on the VM Name on vCenter Internal Name | ||
| ============================= ======================= ====================== ====================== ====================== ===================================== ========================== | ||
| Yes True Name Display name Name i-<user\_id>-<vm\_id>-name i-<user\_id>-<vm\_id>-name | ||
| No True <instance.name>-<UUID> <instance.name>-<UUID> <instance.name>-<UUID> i-<user\_id>-<vm\_id>-<instance.name> <instance.name>-<UUID> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwstppr can you please review the 2nd case, name on vCenter should be "<instance.name>-" and internal name is "i-<user_id>-<vm_id>-<instance.name>"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shwstppr This still needs to be changed, can you please do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done @harikrishna-patnala
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177// Build Log Output: No log errors found to report.// |
1 similar comment
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177// Build Log Output: No log errors found to report.// |
harikrishna-patnala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
requesting docbuild |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177// Build Log Output: No log errors found to report.// |
|
requesting docbuild |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177// Build Log Output: No log errors found to report.// |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177// Build Log Output: No log errors found to report.// |
|
@blueorangutan doc |
|
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/177. (SL-JID 20) |
|
@blueorangutan doc |
1 similar comment
|
@blueorangutan doc |
|
@blueorangutan docbuild |
|
@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/177. (SL-JID 21) |
|
@blueorangutan docbuild |
|
@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/177. (SL-JID 35) |
Backend changes apache/cloudstack#4581
Fixes VM naming convention.
VM name can be controlled with a combination of global settings,
vm.instancename.flagandinstance.namealong withnameparameter ofdeployVirtualMachineAPI. This PR highlights different cases.