Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Jan 12, 2021

Backend changes apache/cloudstack#4581

Fixes VM naming convention.
VM name can be controlled with a combination of global settings, vm.instancename.flag and instance.name along with name parameter of deployVirtualMachine API. This PR highlights different cases.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr self-assigned this Jan 13, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
User-Provided Display Name vm.instancename.flag User Display Name Hostname on the VM Name on vCenter Internal Name
============================= ======================= ====================== ====================== ====================== ===================================== ==========================
Yes True Name Display name Name i-<user\_id>-<vm\_id>-name i-<user\_id>-<vm\_id>-name
No True <instance.name>-<UUID> <instance.name>-<UUID> <instance.name>-<UUID> i-<user\_id>-<vm\_id>-<instance.name> <instance.name>-<UUID>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr can you please review the 2nd case, name on vCenter should be "<instance.name>-" and internal name is "i-<user_id>-<vm_id>-<instance.name>"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr This still needs to be changed, can you please do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shwstppr and others added 3 commits January 27, 2021 14:14
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from ACSGitBot Jan 28, 2021
@apache apache deleted a comment from ACSGitBot Jan 28, 2021
@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@apache apache deleted a comment from ACSGitBot Jan 28, 2021
@apache apache deleted a comment from ACSGitBot Jan 28, 2021
@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177//

Build Log Output:

No log errors found to report.//

1 similar comment
@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177//

Build Log Output:

No log errors found to report.//

Copy link
Contributor

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 4, 2021

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177//

Build Log Output:

No log errors found to report.//

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 4, 2021

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177//

Build Log Output:

No log errors found to report.//

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from ACSGitBot Feb 5, 2021
@apache apache deleted a comment from ACSGitBot Feb 5, 2021
@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr177//

Build Log Output:

No log errors found to report.//

@davidjumani
Copy link
Contributor

@blueorangutan doc

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/177. (SL-JID 20)

@davidjumani
Copy link
Contributor

@blueorangutan doc

1 similar comment
@davidjumani
Copy link
Contributor

@blueorangutan doc

@davidjumani
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/177. (SL-JID 21)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/177. (SL-JID 35)

@yadvr yadvr marked this pull request as ready for review March 29, 2021 10:43
@yadvr yadvr merged commit 3411552 into apache:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants