Skip to content

Conversation

@davidjumani
Copy link
Contributor

No description provided.

@davidjumani davidjumani changed the base branch from master to 4.15 April 12, 2021 07:28
@davidjumani davidjumani force-pushed the new-ui branch 2 times, most recently from e9be3dc to acb71c1 Compare April 12, 2021 09:28
@davidjumani
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. (SL-JID 42)

@davidjumani
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. (SL-JID 43)

@davidjumani davidjumani marked this pull request as ready for review April 27, 2021 09:53
@davidjumani
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@davidjumani davidjumani mentioned this pull request Apr 27, 2021
@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. (SL-JID 47)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't verified each page but source/_static/images contains new icons and images. The pages I checked display new images as well. Minor change for enable-disable icon already applied.
Thanks for the effort @davidjumani

@davidjumani
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. (SL-JID 68)

@davidjumani
Copy link
Contributor Author

@blueorangutan docbuild

@blueorangutan
Copy link

Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. (SL-JID 69)

@andrijapanicsb
Copy link
Contributor

LGTM

@andrijapanicsb andrijapanicsb merged commit 4c63db4 into apache:4.15 May 19, 2021
@nvazquez nvazquez added this to the 4.16 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants