Skip to content

Add pre-commit hook mixed-line-ending #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Sep 18, 2025
Merged

Add pre-commit hook mixed-line-ending #274

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9501399
Add `pre-commit` hook `mixed-line-ending`
jbampton Dec 31, 2024
cafa1a1
Merge branch 'staging-site' into add-hook-mixed-line-ending
jbampton Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ repos:
exclude: \.svg$
- id: fix-byte-order-marker
- id: forbid-submodules
#- id: mixed-line-ending
- id: mixed-line-ending
exclude: ^static/img/.*
Copy link
Contributor

@DaanHoogland DaanHoogland Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would need to apply to /blog//.png|jpg|gif as well. I am not sure how advanced the exclude clause syntax is, but sure a lot of images are stowed away in those directories as well.

Copy link
Member Author

@jbampton jbampton Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DaanHoogland it is well overdue you need to install pre-commit on your local machine and actually run it and test your PRs and same for the main CloudStack project.

There are no real changes needed here since the tests have passed and I was only really wanting to exclude SVG files.

Copy link
Contributor

@DaanHoogland DaanHoogland Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, @jbampton , but we do need to add that to the wiki/some readme as well. (nothing to do with this commit)

Copy link
Member Author

@jbampton jbampton Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, @jbampton , but we do need to add that to the wiki/some readme as well. (nothing to do with this commit)

apache/cloudstack#11680

Copy link
Contributor

@DaanHoogland DaanHoogland Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohw. I see you beat me to it. ;) (ref: apache/cloudstack#11680)

- id: trailing-whitespace
args: [--markdown-linebreak-ext=md]
exclude: ^static/.*$