UI: Fix duplicate quickview (for provider column) in backup repository

[sureshanaparti]

Description

This PR fixes duplicate quickview (for provider column) in backup repository, and consolidates the existing quickview for first column, column key.

Quickview for provider column is enabled for OAuth providers only, here: https://github.com/apache/cloudstack/pull/7996/files#diff-fa50e9f30df1f49ab46e9e30d15009ff36b166ce26cb289a8ec75a4f60873d2b

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Primarily verified quick views for the below sections in UI, randomly checked few other sections as well.

• Infrastructure->Backup Repository (first column - Name)
• Configuration->OAuth Configuration (first column - Provider)
• Compute->Instance Snapshots (first column - Display name)
• Storage->Snapshot policies (first column - Interval type)
• Configuration->Guest OS mappings (first column - Hypervisor)
• Tools->Webhooks (first column - Name)

Backup Repository UI, Before Fix:

Backup Repository UI, After Fix:

OAuth Configuration UI, No change:

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (2dbc86a) to head (ac63e7e).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11849   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15542    15544    +2     
=========================================
  Files          5909     5909           
  Lines        529058   529058           
  Branches      64617    64618    +1     
=========================================
+ Hits          92922    92942   +20     
+ Misses       425683   425660   -23     
- Partials      10453    10456    +3     

Flag	Coverage Δ
uitests	3.58% <ø> (-0.01%)	⬇️
unittests	18.63% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11849 (QA-JID-778)

[sureshanaparti]

@DaanHoogland that will enable quick view only in oauthsetting, for provider column. all other views have name column and route is not oauthsetting.

name column is the usual quick view column, only exception is provider column (used in oauthsetting for quick view)

[DaanHoogland]

@DaanHoogland that will enable quick view only in oauthsetting, for provider column. all other views have name column and route is not oauthsetting.

name column is the usual quick view column, only exception is provider column (used in oauthsetting for quick view)

Thanks @sureshanaparti , I had found my erroneous way of thinking and deleted my comment.

[abh1sar]

Hi Suresh,
Please see if the suggested change make sense.
The idea is to show the quick view only on the first column if it is one of [name, provider].
I think this is consistent with the existing UI behaviour and the code seems more maintainable.

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11849 (QA-JID-784)

[abh1sar]

@sureshanaparti The provider column was still showing the quick view with these changes in backup repository.

I have suggested a change in quickViewEnabled(). Can we keep the check that the column has to be the first column? Also can we remove all checks regarding column names (name, provider, hypervisor etc)? These are already being checked before calling quickViewEnabled in the parent elements.

[abh1sar]

Suggested change

	return actions.length > 0 &&
	(columns && ['name', 'provider', 'hypervisor', 'intervaltype'].includes(columns[0].dataIndex) || ['displayname'].includes(key)) &&
	return actions.length > 0 && key == columns[0].dataIndex &&