Skip to content

Deal with Storage Manager tech debt #12321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DaanHoogland wants to merge 1 commit into
base: main
Choose a base branch
from
+375 −644

Deal with Storage Manager tech debt

7d7e5df
Select commit
Loading
Failed to load commit list.
Draft

Deal with Storage Manager tech debt #12321

Deal with Storage Manager tech debt
7d7e5df
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 30, 2025 in 0s

17.51% (+0.00%) compared to 5bf869c

View this Pull Request on Codecov

17.51% (+0.00%) compared to 5bf869c

Details

Codecov Report

❌ Patch coverage is 23.22275% with 162 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.51%. Comparing base (5bf869c) to head (7d7e5df).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java 20.12% 120 Missing and 3 partials ⚠️
.../api/command/admin/storage/AddImageStoreS3CMD.java 0.00% 9 Missing ⚠️
...loudstack/api/command/admin/swift/AddSwiftCmd.java 0.00% 9 Missing ⚠️
...api/command/admin/host/AddSecondaryStorageCmd.java 0.00% 8 Missing ⚠️
...ge/datastore/driver/SwiftImageStoreDriverImpl.java 0.00% 4 Missing ⚠️
...ck/api/command/admin/storage/AddImageStoreCmd.java 72.72% 3 Missing ⚠️
...orage/datastore/driver/S3ImageStoreDriverImpl.java 0.00% 3 Missing ⚠️
...pi/command/admin/storage/UpdateStoragePoolCmd.java 0.00% 1 Missing ⚠️
...rc/main/java/com/cloud/storage/StorageManager.java 83.33% 0 Missing and 1 partial ⚠️
...storage/cache/manager/StorageCacheManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               main   #12321    +/-   ##
==========================================
  Coverage     17.51%   17.51%            
  Complexity    15585    15585            
==========================================
  Files          5914     5914            
  Lines        529867   529687   -180     
  Branches      64722    64681    -41     
==========================================
- Hits          92782    92766    -16     
+ Misses       426635   426474   -161     
+ Partials      10450    10447     -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov