-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Provide cleanup option to force deleting a project #4453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
code looks ok, but needs tests and primate UI |
@DaanHoogland I have already created pr for ui changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Unable to delete a project if it has resources but can do so by passing cleanup as true
There could be other checks for resources such as ssh keys, etc but the basics are covered
Provide an api support to update volume name by all users Can be done both through api and UI
|
@ravening can you resolve the conflicts, and make primate ui change ? |
Provide an api support to update volume name by all users Can be done both through api and UI
deletes all the resources in the project. If not selected then the project is not deleted if all the resources are not yet cleaned up
7a7fb5b to
ff989e3
Compare
|
@weizhouapache created new pr #4617 |
Description
Provide an option to user which when selected
deletes all the resources in the project.
If not selected then the project is not deleted if
all the resources are not yet cleaned up
Types of changes
Screenshots (if appropriate):
]
How Has This Been Tested?