Skip to content

Conversation

@ravening
Copy link
Member

@ravening ravening commented Nov 6, 2020

Description

Provide an option to user which when selected
deletes all the resources in the project.
If not selected then the project is not deleted if
all the resources are not yet cleaned up

Types of changes

  • Enhancement (improves an existing feature and functionality)

Screenshots (if appropriate):

Screenshot 2020-11-06 at 14 25 38
]

How Has This Been Tested?

@DaanHoogland
Copy link
Contributor

code looks ok, but needs tests and primate UI

@ravening
Copy link
Member Author

code looks ok, but needs tests and primate UI

@DaanHoogland I have already created pr for ui changes

Copy link
Contributor

@davidjumani davidjumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unable to delete a project if it has resources but can do so by passing cleanup as true
There could be other checks for resources such as ssh keys, etc but the basics are covered

Provide an api support to update volume name by all users
Can be done both through api and UI
@weizhouapache
Copy link
Member

@ravening can you resolve the conflicts, and make primate ui change ?

Provide an api support to update volume name by all users
Can be done both through api and UI
deletes all the resources in the project.
If not selected then the project is not deleted if
all the resources are not yet cleaned up
@ravening ravening closed this Jan 26, 2021
@ravening ravening deleted the cleanup-project branch January 26, 2021 11:14
@ravening
Copy link
Member Author

ravening commented Jan 26, 2021

@weizhouapache created new pr #4617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants