Skip to content

Conversation

@utchoang
Copy link

@utchoang utchoang commented Mar 17, 2021

Description

Related apache/cloudstack-primate#844
This PR to fix show display text instead of the name

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@utchoang
Copy link
Author

@blueorangutan ui

@blueorangutan
Copy link

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4831 (SL-JID-33)

@rohityadavcloud rohityadavcloud added this to the 4.15.1.0 milestone Mar 17, 2021
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we need someone to manually check the create network cases (from deploy VM form and network -> add network)

@rohityadavcloud
Copy link
Member

@shwstppr was a manual test done?

@shwstppr
Copy link
Contributor

@rhtyd yes, tested network forms from Networks section and zone's traffic type tab

@rohityadavcloud rohityadavcloud merged commit d105d6a into apache:4.15 Mar 18, 2021
@utchoang utchoang deleted the feature/networkoffering-show-displaytext branch March 23, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants